mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-30 14:54:59 +01:00
Factor out a Pattern sum type from Expression (#685)
`Pattern` is intended to pilot some changes I would like to apply to all our sum types: - The alternatives are expressed as derived classes rather than members of a `std::variant`. - The alternatives are classes in the [style guide sense](https://google.github.io/styleguide/cppguide.html#Structs_vs._Classes), meaning they can have invariants, but can't have public data members. - Creating an object is expressed using a constructor rather than a factory function. - Accessing an alternative is expressed as a cast (using LLVM's RTTI system) rather than `std::get` or a `Get` method. Co-authored-by: Jon Meow <46229924+jonmeow@users.noreply.github.com>
This commit is contained in:
committed by
GitHub
co-authored by
Jon Meow
parent
b08f6bb0f1
commit
6ac3adfa53
@@ -7,6 +7,7 @@
|
||||
|
||||
#include "common/ostream.h"
|
||||
#include "executable_semantics/ast/expression.h"
|
||||
#include "executable_semantics/ast/pattern.h"
|
||||
#include "executable_semantics/ast/statement.h"
|
||||
#include "llvm/Support/Compiler.h"
|
||||
|
||||
@@ -23,8 +24,8 @@ struct FunctionDefinition {
|
||||
FunctionDefinition() = default;
|
||||
FunctionDefinition(int line_num, std::string name,
|
||||
std::vector<GenericBinding> deduced_params,
|
||||
const Expression* param_pattern,
|
||||
const Expression* return_type, const Statement* body)
|
||||
const TuplePattern* param_pattern,
|
||||
const Pattern* return_type, const Statement* body)
|
||||
: line_num(line_num),
|
||||
name(std::move(name)),
|
||||
deduced_parameters(deduced_params),
|
||||
@@ -39,8 +40,8 @@ struct FunctionDefinition {
|
||||
int line_num;
|
||||
std::string name;
|
||||
std::vector<GenericBinding> deduced_parameters;
|
||||
const Expression* param_pattern;
|
||||
const Expression* return_type;
|
||||
const TuplePattern* param_pattern;
|
||||
const Pattern* return_type;
|
||||
const Statement* body;
|
||||
};
|
||||
|
||||
|
||||
Reference in New Issue
Block a user