carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-04 10:41:05 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Split Semantics into Check and SemIR namespaces (#3138)

Browse Source 
Splits IR files into SemIR, and logic files into Check. These will be
split into separate directories as part of a later move; the namespaces
are being done first in order to vet the switch, and hopefully make
conflicts a little easier to manage due to the substantial renames.

A lot of this is just automated removal of Semantics prefixes from
names, adding namespace references where needed. A few special-cases
are:

- SemanticsIR -> SemIR::File
- A few things were discussed, like Unit, CompileUnit, or CompiledUnit.
Unit was too vague for chandlerc, and I thought CompileUnit might lead
to incorrect inferences (CompilationUnit would be more precise, but
typically written as SemIR::CompilationUnit which is pretty long). File
seemed to be a short name that we could agree on.
- SemanticsIRFormatter -> SemIR::Formatter
- FormatSemanticsIR -> SemIR::FormatFile
- SemanticsFileTest -> CheckFileTest
- It remains in the Testing namespace, where just "FileTest" might be
too broad a name.
- SemanticsDeclarationNameStack::Context ->
Check::DeclarationNameStack::NameContext
  - This avoids a Check::Context name shadowing.

Changes check_internal.h to include ostream.h to improve finding of
Print/operator<< (otherwise it didn't compile).

This is part of #3070
This commit is contained in:
Jon Ross-Perkins
2023-08-23 22:51:23 +00:00
committed by GitHub
parent b2db2ca7cf
commit 67da700dd5
53 changed files with 1337 additions and 1466 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/semantics/semantics_handle_loop_statement.cpp
+21 -24
View File
@@ -5,61 +5,58 @@
#include "toolchain/semantics/semantics_context.h"
#include "toolchain/semantics/semantics_node.h"
namespace Carbon {
namespace Carbon::Check {
auto SemanticsHandleBreakStatement(SemanticsContext& context,
ParseTree::Node parse_node) -> bool {
auto HandleBreakStatement(Context& context, ParseTree::Node parse_node)
-> bool {
return context.TODO(parse_node, "HandleBreakStatement");
}
auto SemanticsHandleBreakStatementStart(SemanticsContext& context,
ParseTree::Node parse_node) -> bool {
auto HandleBreakStatementStart(Context& context, ParseTree::Node parse_node)
-> bool {
return context.TODO(parse_node, "HandleBreakStatementStart");
}
auto SemanticsHandleContinueStatement(SemanticsContext& context,
ParseTree::Node parse_node) -> bool {
auto HandleContinueStatement(Context& context, ParseTree::Node parse_node)
-> bool {
return context.TODO(parse_node, "HandleContinueStatement");
}
auto SemanticsHandleContinueStatementStart(SemanticsContext& context,
ParseTree::Node parse_node) -> bool {
auto HandleContinueStatementStart(Context& context, ParseTree::Node parse_node)
-> bool {
return context.TODO(parse_node, "HandleContinueStatementStart");
}
auto SemanticsHandleForHeader(SemanticsContext& context,
ParseTree::Node parse_node) -> bool {
auto HandleForHeader(Context& context, ParseTree::Node parse_node) -> bool {
return context.TODO(parse_node, "HandleForHeader");
}
auto SemanticsHandleForHeaderStart(SemanticsContext& context,
ParseTree::Node parse_node) -> bool {
auto HandleForHeaderStart(Context& context, ParseTree::Node parse_node)
-> bool {
return context.TODO(parse_node, "HandleForHeaderStart");
}
auto SemanticsHandleForIn(SemanticsContext& context, ParseTree::Node parse_node)
-> bool {
auto HandleForIn(Context& context, ParseTree::Node parse_node) -> bool {
return context.TODO(parse_node, "HandleForIn");
}
auto SemanticsHandleForStatement(SemanticsContext& context,
ParseTree::Node parse_node) -> bool {
auto HandleForStatement(Context& context, ParseTree::Node parse_node) -> bool {
return context.TODO(parse_node, "HandleForStatement");
}
auto SemanticsHandleWhileCondition(SemanticsContext& context,
ParseTree::Node parse_node) -> bool {
auto HandleWhileCondition(Context& context, ParseTree::Node parse_node)
-> bool {
return context.TODO(parse_node, "HandleWhileCondition");
}
auto SemanticsHandleWhileConditionStart(SemanticsContext& context,
ParseTree::Node parse_node) -> bool {
auto HandleWhileConditionStart(Context& context, ParseTree::Node parse_node)
-> bool {
return context.TODO(parse_node, "HandleWhileConditionStart");
}
auto SemanticsHandleWhileStatement(SemanticsContext& context,
ParseTree::Node parse_node) -> bool {
auto HandleWhileStatement(Context& context, ParseTree::Node parse_node)
-> bool {
return context.TODO(parse_node, "HandleWhileStatement");
}
} // namespace Carbon
} // namespace Carbon::Check