carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Add Self to the name scope for a class. (#3736)

Browse Source 
Rather than just adding `Self` to the lexical scope, add it to the
class's name scope so that it is visible in later lexical scopes for the
same class -- in particular, for out-of-line definitions of members.
Also switch some tests in `check/testdata/class` over to making
idiomatic use of `Self` both inside a class and out-of-line, now that it
works more consistently.

Note that this does not permit using `Class.Self`, but only because we
don't yet support keyword names after `.` at all. If that changed, one
could use `Class.Self` to redundantly refer to `Class`. Whether we allow
that is left to a future decision.
This commit is contained in:
Richard Smith
2024-02-29 21:33:47 +00:00
committed by GitHub
parent a6f4752a7b
commit 67d5446b03
81 changed files with 535 additions and 193 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/testdata/class/fail_method_modifiers.carbon
Vendored
+3
View File
@@ -80,6 +80,7 @@ base class BaseClass {
// CHECK:STDOUT: } [template]
// CHECK:STDOUT:
// CHECK:STDOUT: !members:
// CHECK:STDOUT: .Self = constants.%FinalClass
// CHECK:STDOUT: .Abstract = %Abstract
// CHECK:STDOUT: .Virtual = %Virtual
// CHECK:STDOUT: }
@@ -97,6 +98,7 @@ base class BaseClass {
// CHECK:STDOUT: } [template]
// CHECK:STDOUT:
// CHECK:STDOUT: !members:
// CHECK:STDOUT: .Self = constants.%AbstractClass
// CHECK:STDOUT: .Default = %Default
// CHECK:STDOUT: .Final = %Final
// CHECK:STDOUT: }
@@ -109,6 +111,7 @@ base class BaseClass {
// CHECK:STDOUT: } [template]
// CHECK:STDOUT:
// CHECK:STDOUT: !members:
// CHECK:STDOUT: .Self = constants.%BaseClass
// CHECK:STDOUT: .Abstract = %Abstract
// CHECK:STDOUT: }
// CHECK:STDOUT: