carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Style updates, mostly _ naming (#970)

Browse Source 
There are some declaration order changes, and a few test classes switched from `struct` to `class`. However, this PR is mostly adopting `_` naming of private member variables due to the shift in naming style. None of what's here should have behavior impacts, it should just be style.

Note, there are a lot of things that *look* like they could be accessor-named, but I'm not doing that in this change. Happy to do it separately if you want me to do another PR focused on it.

Co-authored-by: Chandler Carruth <chandlerc@gmail.com>
This commit is contained in:
Jon Meow
2021-12-07 09:46:44 -08:00
committed by GitHub
co-authored by Chandler Carruth
parent be8d0a993b
commit 652cd8c636
29 changed files with 491 additions and 481 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/source/source_buffer.h
+10 -10
View File
@@ -71,6 +71,16 @@ class SourceBuffer {
[[nodiscard]] auto Text() const -> llvm::StringRef { return text_; }
private:
SourceBuffer(llvm::StringRef fake_filename, std::string buffer_text)
: filename_(fake_filename.str()),
is_string_rep_(true),
string_storage_(std::move(buffer_text)) {
text_ = string_storage_;
}
explicit SourceBuffer(llvm::StringRef filename)
: filename_(filename.str()), text_(), is_string_rep_(false) {}
std::string filename_;
llvm::StringRef text_;
@@ -83,16 +93,6 @@ class SourceBuffer {
union {
std::string string_storage_;
};
explicit SourceBuffer(llvm::StringRef fake_filename, std::string buffer_text)
: filename_(fake_filename.str()),
is_string_rep_(true),
string_storage_(std::move(buffer_text)) {
text_ = string_storage_;
}
explicit SourceBuffer(llvm::StringRef filename)
: filename_(filename.str()), text_(), is_string_rep_(false) {}
};
} // namespace Carbon