carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-06 07:24:42 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Use the DeclNameStack for impl declarations. (#3691)

Browse Source 
They don't have names, but using the DeclNameStack anyway keeps our
behavior more consistent, and keeps track of the enclosing name scope
and the prior state of the scope stack for us.

Depends on #3683.
This commit is contained in:
Richard Smith
2024-02-06 22:28:31 +00:00
committed by GitHub
parent da34f61ef9
commit 5ab26072fd
4 changed files with 57 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/node_stack.h
+2 -3
View File
@@ -356,7 +356,7 @@ class NodeStack {
// that the parse node should not appear in the node stack at all.
using Id = IdUnion<SemIR::InstId, SemIR::InstBlockId, SemIR::FunctionId,
SemIR::ClassId, SemIR::InterfaceId, SemIR::ImplId,
SemIR::NameId, SemIR::NameScopeId, SemIR::TypeId>;
SemIR::NameId, SemIR::TypeId>;
// An entry in stack_.
struct Entry {
@@ -452,8 +452,6 @@ class NodeStack {
return Id::KindFor<SemIR::ImplId>();
case Parse::NodeKind::SelfValueName:
return Id::KindFor<SemIR::NameId>();
case Parse::NodeKind::ImplIntroducer:
return Id::KindFor<SemIR::NameScopeId>();
case Parse::NodeKind::ArrayExprSemi:
case Parse::NodeKind::ClassIntroducer:
case Parse::NodeKind::CodeBlockStart:
@@ -461,6 +459,7 @@ class NodeStack {
case Parse::NodeKind::FunctionIntroducer:
case Parse::NodeKind::IfStatementElse:
case Parse::NodeKind::ImplicitParamListStart:
case Parse::NodeKind::ImplIntroducer:
case Parse::NodeKind::InterfaceIntroducer:
case Parse::NodeKind::LetIntroducer:
case Parse::NodeKind::QualifiedName: