carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-04 15:31:08 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Link to comments as they are in files. (#133)

Browse Source
This commit is contained in:
Jon Meow
2020-07-31 08:24:47 -07:00
committed by GitHub
parent d031f3cdab
commit 598283cd5c
2 changed files with 69 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/scripts/pr_comments_test.py
+24 -5
View File
@@ -90,7 +90,11 @@ class TestPRComments(unittest.TestCase):
@staticmethod
def fake_thread(**kwargs):
return pr_comments._Thread(TestPRComments.fake_thread_dict(**kwargs))
with mock.patch.dict(os.environ, {}):
parsed_args = pr_comments._parse_args(["83"])
return pr_comments._Thread(
parsed_args, TestPRComments.fake_thread_dict(**kwargs)
)
@staticmethod
def fake_thread_dict(
@@ -98,8 +102,9 @@ class TestPRComments(unittest.TestCase):
path="foo.md",
line=3,
created_at="2001-02-03T04:05:06Z",
original_commit=None,
):
return {
thread_dict = {
"isResolved": is_resolved,
"comments": {
"nodes": [
@@ -118,11 +123,17 @@ class TestPRComments(unittest.TestCase):
},
],
},
"resolvedBy": {
}
if is_resolved:
thread_dict["resolvedBy"] = {
"login": "resolver",
"createdAt": "2001-02-03T04:25:26Z",
},
}
}
if original_commit:
thread_dict["comments"]["nodes"][0]["originalCommit"] = {
"abbreviatedOid": original_commit,
}
return thread_dict
def test_thread_format(self):
self.assertEqual(
@@ -161,6 +172,14 @@ class TestPRComments(unittest.TestCase):
" resolver at 2001-02-03 04:25:\n"
" <resolved>",
)
self.assertEqual(
self.fake_thread(original_commit="abcdef").format(False),
"line 3; unresolved\n"
" COMMENT: https://github.com/carbon-language/carbon-lang/pull/83/files/abcdef#diff-d8ca3b3d314d8209367af0eea2373b6fR3\n"
" CHANGES: https://github.com/carbon-language/carbon-lang/pull/83/files/abcdef..HEAD#diff-d8ca3b3d314d8209367af0eea2373b6fL3\n"
" author: comment\n"
" other: reply",
)
def test_thread_lt(self):
thread1 = self.fake_thread(line=2)