carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Support for user-defined Eq impls (#1730)

Browse Source 
Related to #1549; user-defined equality is a prerequisite for user-defined comparison.
This commit is contained in:
Thejaswi Kadur
2022-07-30 11:51:39 -07:00
committed by GitHub
parent b988d5353c
commit 5665f32bf7
18 changed files with 237 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
explorer/interpreter/interpreter.cpp
+19 -3
View File
@@ -203,8 +203,6 @@ auto Interpreter::EvalPrim(Operator op, Nonnull<const Value*> static_type,
case Operator::Or:
return arena_->New<BoolValue>(cast<BoolValue>(*args[0]).value() ||
cast<BoolValue>(*args[1]).value());
case Operator::Eq:
return arena_->New<BoolValue>(ValueEqual(args[0], args[1], std::nullopt));
case Operator::Ptr:
return arena_->New<PointerType>(args[0]);
case Operator::Deref:
@@ -214,7 +212,9 @@ auto Interpreter::EvalPrim(Operator op, Nonnull<const Value*> static_type,
case Operator::Combine:
return &cast<TypeOfConstraintType>(static_type)->constraint_type();
case Operator::As:
return Convert(args[0], args[1], source_loc);
case Operator::Eq:
CARBON_FATAL() << "These operators should have been rewritten to "
"interface method calls";
}
}
@@ -1211,6 +1211,22 @@ auto Interpreter::StepExp() -> ErrorOr<Success> {
heap_.Deallocate(cast<PointerValue>(args.elements()[0])->address());
return todo_.FinishAction(TupleValue::Empty());
}
case IntrinsicExpression::Intrinsic::IntEq: {
const auto& args = cast<TupleValue>(*act.results()[0]).elements();
CARBON_CHECK(args.size() == 2);
auto lhs = cast<IntValue>(*args[0]).value();
auto rhs = cast<IntValue>(*args[1]).value();
auto result = arena_->New<BoolValue>(lhs == rhs);
return todo_.FinishAction(result);
}
case IntrinsicExpression::Intrinsic::StrEq: {
const auto& args = cast<TupleValue>(*act.results()[0]).elements();
CARBON_CHECK(args.size() == 2);
auto& lhs = cast<StringValue>(*args[0]).value();
auto& rhs = cast<StringValue>(*args[1]).value();
auto result = arena_->New<BoolValue>(lhs == rhs);
return todo_.FinishAction(result);
}
}
}
case ExpressionKind::IntTypeLiteral: {