Add name accessor to NamedEntityView (#994)

This required changing BindingPattern::name() to return `"_"` instead of nullopt when representing a `"_"` binding.

Semi-related drive-by fixes:
- Update BindingPlaceholderValue to expose a NamedEntity instead of a string name, and stop exposing its type.
- Drop the unused SourceLocation parameter of ValueEqual
This commit is contained in:
Geoff Romer
2022-01-04 15:53:11 -08:00
committed by GitHub
parent 3f12316d6b
commit 50263483d8
13 changed files with 88 additions and 71 deletions
+2 -2
View File
@@ -46,8 +46,8 @@ void Heap::Deallocate(AllocationId allocation) {
if (alive_[allocation.index_]) {
alive_[allocation.index_] = false;
} else {
FATAL_RUNTIME_ERROR_NO_LINE() << "deallocating an already dead value: "
<< *values_[allocation.index_];
FATAL() << "deallocating an already dead value: "
<< *values_[allocation.index_];
}
}