Add name accessor to NamedEntityView (#994)

This required changing BindingPattern::name() to return `"_"` instead of nullopt when representing a `"_"` binding.

Semi-related drive-by fixes:
- Update BindingPlaceholderValue to expose a NamedEntity instead of a string name, and stop exposing its type.
- Drop the unused SourceLocation parameter of ValueEqual
This commit is contained in:
Geoff Romer
2022-01-04 15:53:11 -08:00
committed by GitHub
parent 3f12316d6b
commit 50263483d8
13 changed files with 88 additions and 71 deletions
+1 -6
View File
@@ -26,12 +26,7 @@ void Pattern::Print(llvm::raw_ostream& out) const {
break;
case PatternKind::BindingPattern: {
const auto& binding = cast<BindingPattern>(*this);
if (binding.name().has_value()) {
out << *binding.name();
} else {
out << "_";
}
out << ": " << binding.type();
out << binding.name() << ": " << binding.type();
break;
}
case PatternKind::TuplePattern: {