carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-09-24 13:50:10 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Fix handling of backticks in proposal names. (#7383)

Browse Source 
Use slugify, as it properly handles all proposal names. This also makes
our branch name consistent with the file name of the proposal.
This commit is contained in:
Richard Smith
2026-06-17 23:17:11 +00:00
committed by GitHub
parent fe58c5e46b
commit 4fcf818b58
2 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
proposals/scripts/new_proposal.py
+1 -2
View File
@@ -93,8 +93,7 @@ def _calculate_branch(parsed_args: argparse.Namespace) -> str:
if parsed_args.branch:
assert isinstance(parsed_args.branch, str)
return parsed_args.branch
# Only use the first 20 chars of the title for branch names.
return "proposal-%s" % (parsed_args.title.lower().replace(" ", "-")[0:20])
return "proposal-%s" % slugify(parsed_args.title)
def _find_tool(tool: str) -> str:
proposals/scripts/new_proposal_test.py
+10 -1
View File
@@ -27,7 +27,16 @@ class TestNewProposal(unittest.TestCase):
)
self.assertEqual(
new_proposal._calculate_branch(parsed_args),
"proposal-a-really-long-long-l",
"proposal-a-really-long-long-long-title",
)
def test_calculate_branch_special(self):
parsed_args = new_proposal._parse_args(
["A title with #*%$ special `char`s"]
)
self.assertEqual(
new_proposal._calculate_branch(parsed_args),
"proposal-a-title-with-special-char-s",
)
def test_calculate_branch_flag(self):