carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Fix TryEvalInstInContext to be static (#4346)

Browse Source 
Also noticed `MakeIntTypeResult` should be static.
This commit is contained in:
Jon Ross-Perkins
2024-09-27 00:22:11 +00:00
committed by GitHub
parent b1f93d0881
commit 4c9ffb0dee
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/eval.cpp
+7 -5
View File
@@ -577,9 +577,9 @@ static auto ValidateIntType(Context& context, SemIRLoc loc,
// Forms a constant int type as an evaluation result. Requires that width_id is
// constant.
auto MakeIntTypeResult(Context& context, SemIRLoc loc, SemIR::IntKind int_kind,
SemIR::InstId width_id, Phase phase)
-> SemIR::ConstantId {
static auto MakeIntTypeResult(Context& context, SemIRLoc loc,
SemIR::IntKind int_kind, SemIR::InstId width_id,
Phase phase) -> SemIR::ConstantId {
auto result = SemIR::IntType{
.type_id = context.GetBuiltinType(SemIR::BuiltinInstKind::TypeType),
.int_kind = int_kind,
@@ -1103,8 +1103,10 @@ static auto MakeConstantForCall(EvalContext& eval_context, SemIRLoc loc,
return SemIR::ConstantId::NotConstant;
}
auto TryEvalInstInContext(EvalContext& eval_context, SemIR::InstId inst_id,
SemIR::Inst inst) -> SemIR::ConstantId {
// Implementation for `TryEvalInst`, wrapping `Context` with `EvalContext`.
static auto TryEvalInstInContext(EvalContext& eval_context,
SemIR::InstId inst_id, SemIR::Inst inst)
-> SemIR::ConstantId {
// TODO: Ensure we have test coverage for each of these cases that can result
// in a constant, once those situations are all reachable.
CARBON_KIND_SWITCH(inst) {