mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-05 22:02:55 +01:00
Add RawStringOstream for slightly simpler streaming to strings (#4817)
This adds a RawStringOstream. Versus TestRawOstream, which is
consolidated over to RawStringOstream, it uses a string for storage
instead of a vector, mainly to support move-to-string semantics. Versus
llvm::raw_string_ostream, it owns the string and supports pwrite (which
is needed for driver and its fd_ostream compatibility requirement).
This converts most uses of llvm::raw_string_ostream, leaving behind a
few in InstNamer that explicitly cannot own the string, such as:
```
llvm::raw_string_ostream(name)
<< "_" << tree.tokens().GetColumnNumber(token);
```
I have this as its own library so that it can use CHECK.
Yes this doesn't save much code, but it's code we repeatedly write.
---------
Co-authored-by: Geoff Romer <gromer@google.com>
This commit is contained in:
co-authored by
Geoff Romer
parent
ef6e035e7d
commit
4c4c4a4d2c
@@ -4,6 +4,7 @@
|
||||
|
||||
#include "toolchain/lower/mangler.h"
|
||||
|
||||
#include "common/raw_string_ostream.h"
|
||||
#include "toolchain/base/kind_switch.h"
|
||||
#include "toolchain/sem_ir/entry_point.h"
|
||||
#include "toolchain/sem_ir/ids.h"
|
||||
@@ -131,8 +132,7 @@ auto Mangler::Mangle(SemIR::FunctionId function_id,
|
||||
CARBON_CHECK(!specific_id.is_valid(), "entry point should not be generic");
|
||||
return "main";
|
||||
}
|
||||
std::string result;
|
||||
llvm::raw_string_ostream os(result);
|
||||
RawStringOstream os;
|
||||
os << "_C";
|
||||
|
||||
os << names().GetAsStringIfIdentifier(function.name_id);
|
||||
@@ -151,7 +151,7 @@ auto Mangler::Mangle(SemIR::FunctionId function_id,
|
||||
llvm::HexPrintStyle::Lower, 16);
|
||||
}
|
||||
|
||||
return os.str();
|
||||
return os.TakeStr();
|
||||
}
|
||||
|
||||
} // namespace Carbon::Lower
|
||||
|
||||
Reference in New Issue
Block a user