mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-05 16:21:04 +01:00
Add RawStringOstream for slightly simpler streaming to strings (#4817)
This adds a RawStringOstream. Versus TestRawOstream, which is
consolidated over to RawStringOstream, it uses a string for storage
instead of a vector, mainly to support move-to-string semantics. Versus
llvm::raw_string_ostream, it owns the string and supports pwrite (which
is needed for driver and its fd_ostream compatibility requirement).
This converts most uses of llvm::raw_string_ostream, leaving behind a
few in InstNamer that explicitly cannot own the string, such as:
```
llvm::raw_string_ostream(name)
<< "_" << tree.tokens().GetColumnNumber(token);
```
I have this as its own library so that it can use CHECK.
Yes this doesn't save much code, but it's code we repeatedly write.
---------
Co-authored-by: Geoff Romer <gromer@google.com>
This commit is contained in:
co-authored by
Geoff Romer
parent
ef6e035e7d
commit
4c4c4a4d2c
@@ -9,6 +9,7 @@
|
||||
#include "absl/strings/string_view.h"
|
||||
#include "common/check.h"
|
||||
#include "common/ostream.h"
|
||||
#include "common/raw_string_ostream.h"
|
||||
#include "llvm/ADT/DenseMap.h"
|
||||
#include "llvm/ADT/StringExtras.h"
|
||||
#include "llvm/Support/FormatVariadic.h"
|
||||
@@ -363,11 +364,11 @@ auto FileTestAutoupdater::Run(bool dry_run) -> bool {
|
||||
}
|
||||
|
||||
// Generate the autoupdated file.
|
||||
std::string new_content;
|
||||
llvm::raw_string_ostream new_content_stream(new_content);
|
||||
RawStringOstream new_content_stream;
|
||||
for (const auto& line : new_lines_) {
|
||||
new_content_stream << *line << '\n';
|
||||
}
|
||||
std::string new_content = new_content_stream.TakeStr();
|
||||
|
||||
// Update the file on disk if needed.
|
||||
if (new_content == input_content_) {
|
||||
|
||||
Reference in New Issue
Block a user