Add RawStringOstream for slightly simpler streaming to strings (#4817)

This adds a RawStringOstream. Versus TestRawOstream, which is
consolidated over to RawStringOstream, it uses a string for storage
instead of a vector, mainly to support move-to-string semantics. Versus
llvm::raw_string_ostream, it owns the string and supports pwrite (which
is needed for driver and its fd_ostream compatibility requirement).

This converts most uses of llvm::raw_string_ostream, leaving behind a
few in InstNamer that explicitly cannot own the string, such as:

```
     llvm::raw_string_ostream(name)
          << "_" << tree.tokens().GetColumnNumber(token);
```

I have this as its own library so that it can use CHECK.

Yes this doesn't save much code, but it's code we repeatedly write.

---------

Co-authored-by: Geoff Romer <gromer@google.com>
This commit is contained in:
Jon Ross-Perkins
2025-01-18 01:11:44 +00:00
committed by GitHub
co-authored by Geoff Romer
parent ef6e035e7d
commit 4c4c4a4d2c
47 changed files with 318 additions and 275 deletions
+6 -6
View File
@@ -10,6 +10,7 @@
#include <concepts>
#include <type_traits>
#include "common/raw_string_ostream.h"
#include "llvm/ADT/Sequence.h"
#include "llvm/ADT/StringExtras.h"
#include "llvm/Support/FormatVariadic.h"
@@ -469,15 +470,14 @@ TEST(HashingTest, TupleRecursion) {
constexpr uint64_t TestSeed = 42ULL * 1024;
auto ToHexBytes(llvm::StringRef s) -> std::string {
std::string rendered;
llvm::raw_string_ostream os(rendered);
os << "{";
RawStringOstream rendered;
rendered << "{";
llvm::ListSeparator sep(", ");
for (const char c : s) {
os << sep << llvm::formatv("{0:x2}", static_cast<uint8_t>(c));
rendered << sep << llvm::formatv("{0:x2}", static_cast<uint8_t>(c));
}
os << "}";
return rendered;
rendered << "}";
return rendered.TakeStr();
}
template <typename T>