mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-01 16:45:52 +01:00
Add RawStringOstream for slightly simpler streaming to strings (#4817)
This adds a RawStringOstream. Versus TestRawOstream, which is
consolidated over to RawStringOstream, it uses a string for storage
instead of a vector, mainly to support move-to-string semantics. Versus
llvm::raw_string_ostream, it owns the string and supports pwrite (which
is needed for driver and its fd_ostream compatibility requirement).
This converts most uses of llvm::raw_string_ostream, leaving behind a
few in InstNamer that explicitly cannot own the string, such as:
```
llvm::raw_string_ostream(name)
<< "_" << tree.tokens().GetColumnNumber(token);
```
I have this as its own library so that it can use CHECK.
Yes this doesn't save much code, but it's code we repeatedly write.
---------
Co-authored-by: Geoff Romer <gromer@google.com>
This commit is contained in:
co-authored by
Geoff Romer
parent
ef6e035e7d
commit
4c4c4a4d2c
@@ -7,7 +7,7 @@
|
||||
#include <gtest/gtest.h>
|
||||
|
||||
#include "common/error_test_helpers.h"
|
||||
#include "testing/base/test_raw_ostream.h"
|
||||
#include "common/raw_string_ostream.h"
|
||||
|
||||
namespace Carbon {
|
||||
namespace {
|
||||
@@ -108,7 +108,7 @@ TEST(ErrorTest, ErrorBuilderOperatorImplicitCast) {
|
||||
|
||||
TEST(ErrorTest, StreamError) {
|
||||
Error result = ErrorBuilder("TestFunc") << "msg";
|
||||
Testing::TestRawOstream result_stream;
|
||||
RawStringOstream result_stream;
|
||||
result_stream << result;
|
||||
EXPECT_EQ(result_stream.TakeStr(), "TestFunc: msg");
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user