carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-04 22:02:52 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Add implied return; at end of non-value-returning functions. (#2942)

Browse Source 
Add validation that every code block in a function is terminated by a sequence of terminating instructions, and that terminators don't appear anywhere else in code blocks.

This required tracking whether we're in a reachable code block. That's done on the fly when we create a new code block; the new `SemanticsNodeBlockId::Unreachable` is used to represent the case where we're not actually creating a code block because we're in unreachable code.
This commit is contained in:
Richard Smith
2023-06-26 15:17:47 -07:00
committed by GitHub
parent 92d73985df
commit 4b69264cb1
76 changed files with 1150 additions and 302 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/semantics/semantics_node_kind.cpp
+12
View File
@@ -11,4 +11,16 @@ CARBON_DEFINE_ENUM_CLASS_NAMES(SemanticsNodeKind) = {
#include "toolchain/semantics/semantics_node_kind.def"
};
auto SemanticsNodeKind::terminator_kind() const -> SemanticsTerminatorKind {
static constexpr SemanticsTerminatorKind Table[] = {
#define CARBON_SEMANTICS_NODE_KIND(Name) SemanticsTerminatorKind::NotTerminator,
#define CARBON_SEMANTICS_TERMINATOR_SEQUENCE_KIND(Name) \
SemanticsTerminatorKind::TerminatorSequence,
#define CARBON_SEMANTICS_TERMINATOR_KIND(Name) \
SemanticsTerminatorKind::Terminator,
#include "toolchain/semantics/semantics_node_kind.def"
};
return Table[AsInt()];
}
} // namespace Carbon