Add implied return; at end of non-value-returning functions. (#2942)

Add validation that every code block in a function is terminated by a sequence of terminating instructions, and that terminators don't appear anywhere else in code blocks.

This required tracking whether we're in a reachable code block. That's done on the fly when we create a new code block; the new `SemanticsNodeBlockId::Unreachable` is used to represent the case where we're not actually creating a code block because we're in unreachable code.
This commit is contained in:
Richard Smith
2023-06-26 15:17:47 -07:00
committed by GitHub
parent 92d73985df
commit 4b69264cb1
76 changed files with 1150 additions and 302 deletions
@@ -12,8 +12,25 @@ auto SemanticsHandleFunctionDeclaration(SemanticsContext& context,
}
auto SemanticsHandleFunctionDefinition(SemanticsContext& context,
ParseTree::Node /*parse_node*/) -> bool {
context.node_stack().PopAndDiscardId(ParseNodeKind::FunctionDefinitionStart);
ParseTree::Node parse_node) -> bool {
auto function_id = context.node_stack().Pop<SemanticsFunctionId>(
ParseNodeKind::FunctionDefinitionStart);
// If the `}` of the function is reachable, reject if we need a return value
// and otherwise add an implicit `return;`.
if (context.is_current_position_reachable()) {
if (context.semantics_ir()
.GetFunction(function_id)
.return_type_id.is_valid()) {
CARBON_DIAGNOSTIC(
MissingReturnStatement, Error,
"Missing `return` at end of function with declared return type.");
context.emitter().Emit(parse_node, MissingReturnStatement);
} else {
context.AddNode(SemanticsNode::Return::Make(parse_node));
}
}
context.return_scope_stack().pop_back();
context.PopScope();
context.node_block_stack().Pop();