carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-04 15:31:08 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Track the start of a signature more accurately (#6760)

Browse Source 
This change ensures that a function signature always starts with an
`IdentifierNameMaybeBeforeSignature` node (renamed from
`IdentifierNameBeforeParams`), even in the case of function declarations
like `fn F -> T` that have no parameter list. As a consequence, this
ensures that we push new entries onto `pattern_block_stack` and
`full_pattern_stack` when we start processing the function signature.
This commit is contained in:
Geoff Romer
2026-02-23 22:46:03 +00:00
committed by GitHub
parent 375a736c42
commit 4a0cf6c1fb
282 changed files with 1041 additions and 1039 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/parse/tree_test.cpp
+7 -5
View File
@@ -103,8 +103,9 @@ TEST_F(TreeTest, PrintPostorderAsYaml) {
Yaml::Mapping(ElementsAre(Pair("kind", "FileStart"), Pair("text", ""))),
Yaml::Mapping(
ElementsAre(Pair("kind", "FunctionIntroducer"), Pair("text", "fn"))),
Yaml::Mapping(ElementsAre(Pair("kind", "IdentifierNameBeforeParams"),
Pair("text", "F"))),
Yaml::Mapping(
ElementsAre(Pair("kind", "IdentifierNameMaybeBeforeSignature"),
Pair("text", "F"))),
Yaml::Mapping(ElementsAre(Pair("kind", "ExplicitParamListStart"),
Pair("text", "("))),
Yaml::Mapping(ElementsAre(Pair("kind", "ExplicitParamList"),
@@ -136,9 +137,10 @@ TEST_F(TreeTest, PrintPreorderAsYaml) {
Yaml::Mapping(ElementsAre(Pair("node_index", "1"),
Pair("kind", "FunctionIntroducer"),
Pair("text", "fn"))),
Yaml::Mapping(ElementsAre(Pair("node_index", "2"),
Pair("kind", "IdentifierNameBeforeParams"),
Pair("text", "F"))),
Yaml::Mapping(
ElementsAre(Pair("node_index", "2"),
Pair("kind", "IdentifierNameMaybeBeforeSignature"),
Pair("text", "F"))),
Yaml::Mapping(ElementsAre(Pair("node_index", "4"),
Pair("kind", "ExplicitParamList"),
Pair("text", ")"), Pair("subtree_size", "2"),