mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-11-18 15:40:28 +00:00
Track the start of a signature more accurately (#6760)
This change ensures that a function signature always starts with an `IdentifierNameMaybeBeforeSignature` node (renamed from `IdentifierNameBeforeParams`), even in the case of function declarations like `fn F -> T` that have no parameter list. As a consequence, this ensures that we push new entries onto `pattern_block_stack` and `full_pattern_stack` when we start processing the function signature.
This commit is contained in:
1 parent
375a736c42
commit
4a0cf6c1fb
282 files changed
+1041
-1039
No files matched your search
@@ -103,8 +103,9 @@ TEST_F(TreeTest, PrintPostorderAsYaml) {
|
||||
Yaml::Mapping(ElementsAre(Pair("kind", "FileStart"), Pair("text", ""))),
|
||||
Yaml::Mapping(
|
||||
ElementsAre(Pair("kind", "FunctionIntroducer"), Pair("text", "fn"))),
|
||||
Yaml::Mapping(ElementsAre(Pair("kind", "IdentifierNameBeforeParams"),
|
||||
Pair("text", "F"))),
|
||||
Yaml::Mapping(
|
||||
ElementsAre(Pair("kind", "IdentifierNameMaybeBeforeSignature"),
|
||||
Pair("text", "F"))),
|
||||
Yaml::Mapping(ElementsAre(Pair("kind", "ExplicitParamListStart"),
|
||||
Pair("text", "("))),
|
||||
Yaml::Mapping(ElementsAre(Pair("kind", "ExplicitParamList"),
|
||||
@@ -136,9 +137,10 @@ TEST_F(TreeTest, PrintPreorderAsYaml) {
|
||||
Yaml::Mapping(ElementsAre(Pair("node_index", "1"),
|
||||
Pair("kind", "FunctionIntroducer"),
|
||||
Pair("text", "fn"))),
|
||||
Yaml::Mapping(ElementsAre(Pair("node_index", "2"),
|
||||
Pair("kind", "IdentifierNameBeforeParams"),
|
||||
Pair("text", "F"))),
|
||||
Yaml::Mapping(
|
||||
ElementsAre(Pair("node_index", "2"),
|
||||
Pair("kind", "IdentifierNameMaybeBeforeSignature"),
|
||||
Pair("text", "F"))),
|
||||
Yaml::Mapping(ElementsAre(Pair("node_index", "4"),
|
||||
Pair("kind", "ExplicitParamList"),
|
||||
Pair("text", ")"), Pair("subtree_size", "2"),
|
||||
|
||||
Reference in new issue
Block a user