carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Track the start of a signature more accurately (#6760)

Browse Source 
This change ensures that a function signature always starts with an
`IdentifierNameMaybeBeforeSignature` node (renamed from
`IdentifierNameBeforeParams`), even in the case of function declarations
like `fn F -> T` that have no parameter list. As a consequence, this
ensures that we push new entries onto `pattern_block_stack` and
`full_pattern_stack` when we start processing the function signature.
This commit is contained in:
Geoff Romer
2026-02-23 22:46:03 +00:00
committed by GitHub
parent 375a736c42
commit 4a0cf6c1fb
282 changed files with 1041 additions and 1039 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/parse/testdata/choice/basic.carbon
Vendored
+5 -5
View File
@@ -19,15 +19,15 @@ choice Ordering {
// CHECK:STDOUT: parse_tree: [
// CHECK:STDOUT: {kind: 'FileStart', text: ''},
// CHECK:STDOUT: {kind: 'ChoiceIntroducer', text: 'choice'},
// CHECK:STDOUT: {kind: 'IdentifierNameNotBeforeParams', text: 'Ordering'},
// CHECK:STDOUT: {kind: 'IdentifierNameNotBeforeSignature', text: 'Ordering'},
// CHECK:STDOUT: {kind: 'ChoiceDefinitionStart', text: '{', subtree_size: 3},
// CHECK:STDOUT: {kind: 'IdentifierNameNotBeforeParams', text: 'Less'},
// CHECK:STDOUT: {kind: 'IdentifierNameNotBeforeSignature', text: 'Less'},
// CHECK:STDOUT: {kind: 'ChoiceAlternativeListComma', text: ','},
// CHECK:STDOUT: {kind: 'IdentifierNameNotBeforeParams', text: 'Equivalent'},
// CHECK:STDOUT: {kind: 'IdentifierNameNotBeforeSignature', text: 'Equivalent'},
// CHECK:STDOUT: {kind: 'ChoiceAlternativeListComma', text: ','},
// CHECK:STDOUT: {kind: 'IdentifierNameNotBeforeParams', text: 'Greater'},
// CHECK:STDOUT: {kind: 'IdentifierNameNotBeforeSignature', text: 'Greater'},
// CHECK:STDOUT: {kind: 'ChoiceAlternativeListComma', text: ','},
// CHECK:STDOUT: {kind: 'IdentifierNameNotBeforeParams', text: 'Incomparable'},
// CHECK:STDOUT: {kind: 'IdentifierNameNotBeforeSignature', text: 'Incomparable'},
// CHECK:STDOUT: {kind: 'ChoiceDefinition', text: '}', subtree_size: 11},
// CHECK:STDOUT: {kind: 'FileEnd', text: ''},
// CHECK:STDOUT: ]