mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-03 17:36:06 +01:00
Track the start of a signature more accurately (#6760)
This change ensures that a function signature always starts with an `IdentifierNameMaybeBeforeSignature` node (renamed from `IdentifierNameBeforeParams`), even in the case of function declarations like `fn F -> T` that have no parameter list. As a consequence, this ensures that we push new entries onto `pattern_block_stack` and `full_pattern_stack` when we start processing the function signature.
This commit is contained in:
@@ -211,7 +211,7 @@ auto HandleExprInPostfix(Context& context) -> void {
|
||||
auto period = context.Consume();
|
||||
if (context.ConsumeAndAddLeafNodeIf(
|
||||
Lex::TokenKind::Identifier,
|
||||
NodeKind::IdentifierNameNotBeforeParams)) {
|
||||
NodeKind::IdentifierNameNotBeforeSignature)) {
|
||||
// OK, `.` identifier.
|
||||
} else if (context.ConsumeAndAddLeafNodeIf(
|
||||
Lex::TokenKind::SelfTypeIdentifier,
|
||||
@@ -224,7 +224,7 @@ auto HandleExprInPostfix(Context& context) -> void {
|
||||
ExpectedIdentifierOrSelfAfterPeriod);
|
||||
// Only consume if it is a number or word.
|
||||
if (context.PositionKind().is_keyword()) {
|
||||
context.AddLeafNode(NodeKind::IdentifierNameNotBeforeParams,
|
||||
context.AddLeafNode(NodeKind::IdentifierNameNotBeforeSignature,
|
||||
context.Consume(), /*has_error=*/true);
|
||||
} else if (context.PositionIs(Lex::TokenKind::IntLiteral)) {
|
||||
context.AddInvalidParse(context.Consume());
|
||||
|
||||
Reference in New Issue
Block a user