carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Start using typed parse node ids in the check stage (#3547)

Browse Source 
Goal is to increase type safety, though more work needs to be done (see
added TODOs).

Note that, after this change, check handlers corresponding to deleted
parse node kinds will no longer compile.

---------

Co-authored-by: Chandler Carruth <chandlerc@gmail.com>
This commit is contained in:
josh11b
2023-12-29 01:28:09 +00:00
committed by GitHub
co-authored by Chandler Carruth
parent a602be89e2
commit 48c986f52d
33 changed files with 368 additions and 277 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/handle_binding_pattern.cpp
+6 -4
View File
@@ -9,7 +9,7 @@
namespace Carbon::Check {
auto HandleAddress(Context& context, Parse::NodeId parse_node) -> bool {
auto HandleAddress(Context& context, Parse::AddressId parse_node) -> bool {
auto self_param_id =
context.node_stack().Pop<Parse::NodeKind::BindingPattern>();
auto self_param = context.insts().TryGetAs<SemIR::BindName>(self_param_id);
@@ -28,12 +28,14 @@ auto HandleAddress(Context& context, Parse::NodeId parse_node) -> bool {
return true;
}
auto HandleGenericBindingPattern(Context& context, Parse::NodeId parse_node)
auto HandleGenericBindingPattern(Context& context,
Parse::GenericBindingPatternId parse_node)
-> bool {
return context.TODO(parse_node, "GenericBindingPattern");
}
auto HandleBindingPattern(Context& context, Parse::NodeId parse_node) -> bool {
auto HandleBindingPattern(Context& context, Parse::BindingPatternId parse_node)
-> bool {
auto [type_node, parsed_type_id] =
context.node_stack().PopExprWithParseNode();
auto type_node_copy = type_node;
@@ -158,7 +160,7 @@ auto HandleBindingPattern(Context& context, Parse::NodeId parse_node) -> bool {
return true;
}
auto HandleTemplate(Context& context, Parse::NodeId parse_node) -> bool {
auto HandleTemplate(Context& context, Parse::TemplateId parse_node) -> bool {
// TODO: diagnose if this occurs in a `var` context.
return context.TODO(parse_node, "HandleTemplate");
}