carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Update TODO for semantic checking (#4821)

Browse Source 
I believe `check_syntax` is already controlling the semantic vs
syntactic merge, added in #4149. Other parts of the TODO are clarified
per discussion. But this is tested, e.g. errors with the bool flipped:

```
 impl i32 as I {
+  // CHECK:STDERR: method.carbon:[[@LINE+6]]:14: error: redeclaration syntax di
ffers here [RedeclParamSyntaxDiffers]
+  // CHECK:STDERR:   fn F[self: i32](other: i32) -> i32 = "int.sadd";
+  // CHECK:STDERR:              ^~~
+  // CHECK:STDERR: method.carbon:[[@LINE-7]]:14: note: comparing with previous
declaration here [RedeclParamSyntaxPrevious]
+  // CHECK:STDERR:   fn F[self: Self](other: Self) -> Self;
+  // CHECK:STDERR:              ^~~~
   fn F[self: i32](other: i32) -> i32 = "int.sadd";
 }
```
This commit is contained in:
Jon Ross-Perkins
2025-01-21 16:50:25 +00:00
committed by GitHub
parent 6636baf392
commit 41b6bb5688
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/impl.cpp
+5 -3
View File
@@ -129,9 +129,11 @@ static auto CheckAssociatedFunctionImplementation(
.generic_id,
self_type_id, witness_inst_id);
// TODO: This should be a semantic check rather than a syntactic one. The
// functions should be allowed to have different signatures as long as we can
// synthesize a suitable thunk.
// TODO: The functions should be allowed to have different signatures as long
// as we can synthesize a suitable thunk. i.e., when there's an implicit
// conversion from the original parameter types to the overriding parameter
// types, and from the overriding return type to the original return type.
// Also, build that thunk.
if (!CheckFunctionTypeMatches(
context, context.functions().Get(impl_function_decl->function_id),
context.functions().Get(interface_function_type.function_id),