carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-06 08:54:47 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Fix lowering crash when a SpecificInst's inst_id doesn't emit a value (#7880)

Browse Source
This commit is contained in:
Nicholas Bishop
2026-10-01 19:17:49 +00:00
committed by GitHub
parent f1bf789481
commit 3dadff7d01
4 changed files with 205 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/lower/handle.cpp
+7 -1
View File
@@ -363,7 +363,13 @@ auto HandleInst(FunctionContext& context, SemIR::InstId inst_id,
CARBON_CHECK(&context.sem_ir() == &context.specific_sem_ir() &&
context.specific_id() == inst.specific_id,
"Runtime specific_inst refers to a different specific");
context.SetLocal(inst_id, context.GetValue(inst.inst_id));
// When lowering templates, the specific may contain instructions that
// neither emit a value during lowering nor have a constant value, so set
// require_value=false.
if (auto* value = context.GetValue(inst.inst_id, /*require_value=*/false)) {
context.SetLocal(inst_id, value);
}
}
auto HandleInst(FunctionContext& context, SemIR::InstId inst_id,