carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-04 22:02:52 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Rename "generic instance" to "specific" throughout the toolchain. (#4165)

Browse Source 
As discussed in toolchain meeting, we want to avoid overloading the
meaning of "instance", and "specific" was the best name we found. It's a
little unorthodox and inventive, but hopefully over time will become as
unsurprising as the term "generic" is.
This commit is contained in:
Richard Smith
2024-07-25 16:42:01 +00:00
committed by GitHub
parent 70c20be91b
commit 3cb769a053
41 changed files with 370 additions and 396 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/sem_ir/function.cpp
+4 -5
View File
@@ -12,7 +12,7 @@ namespace Carbon::SemIR {
auto GetCalleeFunction(const File& sem_ir, InstId callee_id) -> CalleeFunction {
CalleeFunction result = {.function_id = FunctionId::Invalid,
.instance_id = GenericInstanceId::Invalid,
.specific_id = SpecificId::Invalid,
.self_id = InstId::Invalid,
.is_error = false};
@@ -38,17 +38,16 @@ auto GetCalleeFunction(const File& sem_ir, InstId callee_id) -> CalleeFunction {
}
result.function_id = fn_type->function_id;
result.instance_id = fn_type->instance_id;
result.specific_id = fn_type->specific_id;
return result;
}
auto Function::GetDeclaredReturnType(const File& file,
GenericInstanceId specific_id) const
-> TypeId {
SpecificId specific_id) const -> TypeId {
if (!return_storage_id.is_valid()) {
return TypeId::Invalid;
}
return GetTypeInInstance(file, specific_id,
return GetTypeInSpecific(file, specific_id,
file.insts().Get(return_storage_id).type_id());
}