mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-05 22:02:55 +01:00
Support parse/check/lower for char (#5901)
toolchain/check/testdata/builtins/char/basics.carbon and toolchain/lower/testdata/builtins/char.carbon are probably the most interesting tests here. The parse tests is required because this adds a new node kind, and we need coverage of it; but the attached info is minor. There's a fair amount of test churn here because I'm adding the Core.Char and Core.CharLiteral types as new singletons. My intent here is that `CharId` is always a unicode code point, even when the type is a `Char` and thus must be a single UTF-8 code unit (single byte). This mainly means the stored value of a `CharValue` can be printed internally without knowing the type. --------- Co-authored-by: josh11b <15258583+josh11b@users.noreply.github.com> Co-authored-by: Richard Smith <richard@metafoo.co.uk>
This commit is contained in:
co-authored by
josh11b
Richard Smith
parent
9c7e0f6bd5
commit
37d5046ceb
@@ -47,7 +47,7 @@ extern "C" int LLVMFuzzerTestOneInput(const unsigned char* data, size_t size) {
|
||||
|
||||
auto* null_emitter = &Diagnostics::NullEmitter<const char*>();
|
||||
if (literal->kind() == Lex::StringLiteral::Kind::Char) {
|
||||
volatile auto value = literal->ComputeCharValue(*null_emitter);
|
||||
volatile auto value = literal->ComputeCharLiteralValue(*null_emitter);
|
||||
(void)value;
|
||||
} else {
|
||||
llvm::BumpPtrAllocator allocator;
|
||||
|
||||
Reference in New Issue
Block a user