carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Fix top-of-tree Clang build warnings (#7670)

Browse Source 
`-Wunused-template` was added to `-Wunused`, so clean up the things it
found. One of them was a bug in the Clang warning that I've worked
around and reported upstream:

https://github.com/llvm/llvm-project/issues/218429
This commit is contained in:
Chandler Carruth
2026-08-24 15:54:21 +00:00
committed by GitHub
parent 2b9fdd6e42
commit 369b8fd06f
5 changed files with 7 additions and 74 deletions
Download Patch File Download Diff File Expand all files Collapse all files
common/hashing_test.cpp
-35
View File
@@ -491,41 +491,6 @@ struct HashedValue {
using HashedString = HashedValue<std::string>;
template <typename T>
auto PrintFullWidthHex(llvm::raw_ostream& os, T value) {
static_assert(sizeof(T) == 1 || sizeof(T) == 2 || sizeof(T) == 4 ||
sizeof(T) == 8);
// Given the nature of a format string and the good formatting, a nested
// conditional seems like the most readable structure.
// NOLINTBEGIN(readability-avoid-nested-conditional-operator)
os << llvm::formatv(sizeof(T) == 1 ? "{0:x2}"
: sizeof(T) == 2 ? "{0:x4}"
: sizeof(T) == 4 ? "{0:x8}"
: "{0:x16}",
static_cast<uint64_t>(value));
// NOLINTEND(readability-avoid-nested-conditional-operator)
}
template <typename T>
requires std::integral<T>
auto operator<<(llvm::raw_ostream& os, HashedValue<T> hv)
-> llvm::raw_ostream& {
os << "hash " << hv.hash << " for value ";
PrintFullWidthHex(os, hv.v);
return os;
}
template <typename T, typename U>
requires std::integral<T> && std::integral<U>
auto operator<<(llvm::raw_ostream& os, HashedValue<std::pair<T, U>> hv)
-> llvm::raw_ostream& {
os << "hash " << hv.hash << " for pair of ";
PrintFullWidthHex(os, hv.v.first);
os << " and ";
PrintFullWidthHex(os, hv.v.second);
return os;
}
struct Collisions {
int total;
int median;