carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 21:51:12 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Rename Parse::Node -> Parse::NodeId. (#3432)

Browse Source 
As discussed [on
discord](https://discord.com/channels/655572317891461132/655578254970716160/1178878128714678282)
and today's toolchain discussion.
This commit is contained in:
Richard Smith
2023-11-29 18:53:12 +00:00
committed by GitHub
parent 0c0998d7cd
commit 332a368cee
45 changed files with 396 additions and 372 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/return.cpp
+6 -6
View File
@@ -57,9 +57,9 @@ static auto NoteReturnedVar(Context& context, Context::DiagnosticBuilder& diag,
diag.Note(context.insts().Get(returned_var_id).parse_node(), ReturnedVarHere);
}
auto CheckReturnedVar(Context& context, Parse::Node returned_node,
Parse::Node name_node, SemIR::NameId name_id,
Parse::Node type_node, SemIR::TypeId type_id)
auto CheckReturnedVar(Context& context, Parse::NodeId returned_node,
Parse::NodeId name_node, SemIR::NameId name_id,
Parse::NodeId type_node, SemIR::TypeId type_id)
-> SemIR::InstId {
// A `returned var` requires an explicit return type.
auto& function = GetCurrentFunction(context);
@@ -108,7 +108,7 @@ auto RegisterReturnedVar(Context& context, SemIR::InstId bind_id) -> void {
}
}
auto BuildReturnWithNoExpr(Context& context, Parse::Node parse_node) -> void {
auto BuildReturnWithNoExpr(Context& context, Parse::NodeId parse_node) -> void {
const auto& function = GetCurrentFunction(context);
if (function.return_type_id.is_valid()) {
@@ -124,7 +124,7 @@ auto BuildReturnWithNoExpr(Context& context, Parse::Node parse_node) -> void {
context.AddInst(SemIR::Return{parse_node});
}
auto BuildReturnWithExpr(Context& context, Parse::Node parse_node,
auto BuildReturnWithExpr(Context& context, Parse::NodeId parse_node,
SemIR::InstId expr_id) -> void {
const auto& function = GetCurrentFunction(context);
auto returned_var_id = GetCurrentReturnedVar(context);
@@ -156,7 +156,7 @@ auto BuildReturnWithExpr(Context& context, Parse::Node parse_node,
context.AddInst(SemIR::ReturnExpr{parse_node, expr_id});
}
auto BuildReturnVar(Context& context, Parse::Node parse_node) -> void {
auto BuildReturnVar(Context& context, Parse::NodeId parse_node) -> void {
const auto& function = GetCurrentFunction(context);
auto returned_var_id = GetCurrentReturnedVar(context);