carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-03 11:55:51 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Factor param/arg ref logic to a class. (#3728)

Browse Source 
Just segmenting out a chunk of logic while I'm thinking about function
parameters.
This commit is contained in:
Jon Ross-Perkins
2024-02-27 19:58:19 +00:00
committed by GitHub
parent 85ce06f854
commit 2fee4d072f
10 changed files with 138 additions and 95 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/handle_struct.cpp
+4 -4
View File
@@ -16,7 +16,7 @@ auto HandleStructLiteralOrStructTypeLiteralStart(
// so we push onto args irrespective. It just won't be used for a type
// literal.
context.args_type_info_stack().Push();
context.ParamOrArgStart();
context.param_and_arg_refs_stack().Push();
return true;
}
@@ -30,7 +30,7 @@ auto HandleStructFieldDesignator(Context& context,
auto HandleStructComma(Context& context, Parse::StructCommaId /*parse_node*/)
-> bool {
context.ParamOrArgComma();
context.param_and_arg_refs_stack().ApplyComma();
return true;
}
@@ -91,7 +91,7 @@ static auto DiagnoseDuplicateNames(Context& context,
auto HandleStructLiteral(Context& context, Parse::StructLiteralId parse_node)
-> bool {
auto refs_id = context.ParamOrArgEnd(
auto refs_id = context.param_and_arg_refs_stack().EndAndPop(
Parse::NodeKind::StructLiteralOrStructTypeLiteralStart);
context.scope_stack().Pop();
@@ -114,7 +114,7 @@ auto HandleStructLiteral(Context& context, Parse::StructLiteralId parse_node)
auto HandleStructTypeLiteral(Context& context,
Parse::StructTypeLiteralId parse_node) -> bool {
auto refs_id = context.ParamOrArgEnd(
auto refs_id = context.param_and_arg_refs_stack().EndAndPop(
Parse::NodeKind::StructLiteralOrStructTypeLiteralStart);
context.scope_stack().Pop();