carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-06 06:54:44 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Minor clang-tidy recommended cleanup (#5248)

Browse Source 
Some minor code health improvements discovered by clang-tidy:

* avoid copying; use const reference
* harmonize parameter names
* use more efficient absl::StrSplit-by-character
This commit is contained in:
Thomas Köppe
2025-04-04 17:49:40 +00:00
committed by GitHub
parent 5e338d544e
commit 2fa2425ef5
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
explorer/file_test.cpp
+1 -1
View File
@@ -122,7 +122,7 @@ class ExplorerFileTest : public FileTestBase {
auto GetFileTestManifest() -> llvm::SmallVector<std::string> {
llvm::SmallVector<std::string> manifest;
auto content = ReadFile(absl::GetFlag(FLAGS_explorer_test_targets_file));
for (const auto& line : absl::StrSplit(*content, "\n", absl::SkipEmpty())) {
for (const auto& line : absl::StrSplit(*content, '\n', absl::SkipEmpty())) {
manifest.push_back(std::string(line));
}
return manifest;