carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Migrate remaining exits to FATAL_*_ERROR calls (#704)

Browse Source 
Adds FATAL for things that are most likely programming errors in executable_semantics.
This commit is contained in:
Jon Meow
2021-08-06 13:06:25 -07:00
committed by GitHub
parent 5749413b28
commit 2e9e4f4cb3
23 changed files with 99 additions and 150 deletions
Download Patch File Download Diff File Expand all files Collapse all files
common/check_test.cpp
+12 -2
View File
@@ -11,7 +11,7 @@ namespace Carbon {
TEST(CheckTest, CheckTrue) { CHECK(true); }
TEST(CheckTest, CheckFalse) {
ASSERT_DEATH({ CHECK(false); }, "CHECK failure: false");
ASSERT_DEATH({ CHECK(false); }, "\nCHECK failure: false\n");
}
TEST(CheckTest, CheckTrueCallbackNotUsed) {
@@ -25,7 +25,7 @@ TEST(CheckTest, CheckTrueCallbackNotUsed) {
}
TEST(CheckTest, CheckFalseMessage) {
ASSERT_DEATH({ CHECK(false) << "msg"; }, "CHECK failure: false: msg");
ASSERT_DEATH({ CHECK(false) << "msg"; }, "\nCHECK failure: false: msg\n");
}
TEST(CheckTest, CheckOutputForms) {
@@ -35,4 +35,14 @@ TEST(CheckTest, CheckOutputForms) {
CHECK(true) << msg << str << i << 0;
}
TEST(CheckTest, Fatal) {
ASSERT_DEATH({ FATAL() << "msg"; }, "\nFATAL: msg\n");
}
auto FatalNoReturnRequired() -> int { FATAL() << "msg"; }
TEST(ErrorTest, FatalNoReturnRequired) {
ASSERT_DEATH({ FatalNoReturnRequired(); }, "\nFATAL: msg\n");
}
} // namespace Carbon