carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 11:11:05 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Move diagnostic kind name to the end of the diagnostic. (#4437)

Browse Source 
Also surround it in square brackets rather than parentheses. This
matches the format used by Clang and GCC, and means diagnostics will
still match the `file:line:col: error: ` pattern used by some IDE tools.

Before:
```console
fail_builtins.carbon:11:11: error(AliasRequiresNameRef): alias initializer must be a name reference
```

After:
```console
fail_builtins.carbon:11:11: error: alias initializer must be a name reference [AliasRequiresNameRef]
```

Also tighten up test regex to only match on `STDERR` lines that list a
file name.
This commit is contained in:
Richard Smith
2024-10-23 16:56:23 +00:00
committed by GitHub
parent f206072216
commit 2e63da1a40
528 changed files with 1929 additions and 1928 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/parse/testdata/while/fail_missing_cond.carbon
Vendored
+1 -1
View File
@@ -9,7 +9,7 @@
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/parse/testdata/while/fail_missing_cond.carbon
fn F() {
// CHECK:STDERR: fail_missing_cond.carbon:[[@LINE+3]]:9: error(ExpectedParenAfter): expected `(` after `while`
// CHECK:STDERR: fail_missing_cond.carbon:[[@LINE+3]]:9: error: expected `(` after `while` [ExpectedParenAfter]
// CHECK:STDERR: while {
// CHECK:STDERR: ^
while {
toolchain/parse/testdata/while/fail_no_semi.carbon
Vendored
+2 -2
View File
@@ -12,14 +12,14 @@ fn F() {
while (a) {
if (b) {
break
// CHECK:STDERR: fail_no_semi.carbon:[[@LINE+4]]:5: error(ExpectedStatementSemi): `break` statements must end with a `;`
// CHECK:STDERR: fail_no_semi.carbon:[[@LINE+4]]:5: error: `break` statements must end with a `;` [ExpectedStatementSemi]
// CHECK:STDERR: }
// CHECK:STDERR: ^
// CHECK:STDERR:
}
if (c) {
continue
// CHECK:STDERR: fail_no_semi.carbon:[[@LINE+3]]:5: error(ExpectedStatementSemi): `continue` statements must end with a `;`
// CHECK:STDERR: fail_no_semi.carbon:[[@LINE+3]]:5: error: `continue` statements must end with a `;` [ExpectedStatementSemi]
// CHECK:STDERR: }
// CHECK:STDERR: ^
}
toolchain/parse/testdata/while/fail_unbraced.carbon
Vendored
+1 -1
View File
@@ -11,7 +11,7 @@
fn F() {
while (a)
// CHECK:STDERR: fail_unbraced.carbon:[[@LINE+3]]:5: error(ExpectedCodeBlock): expected braced code block
// CHECK:STDERR: fail_unbraced.carbon:[[@LINE+3]]:5: error: expected braced code block [ExpectedCodeBlock]
// CHECK:STDERR: break;
// CHECK:STDERR: ^~~~~
break;