Move diagnostic kind name to the end of the diagnostic. (#4437)

Also surround it in square brackets rather than parentheses. This
matches the format used by Clang and GCC, and means diagnostics will
still match the `file:line:col: error: ` pattern used by some IDE tools.

Before:
```console
fail_builtins.carbon:11:11: error(AliasRequiresNameRef): alias initializer must be a name reference
```

After:
```console
fail_builtins.carbon:11:11: error: alias initializer must be a name reference [AliasRequiresNameRef]
```

Also tighten up test regex to only match on `STDERR` lines that list a
file name.
This commit is contained in:
Richard Smith
2024-10-23 16:56:23 +00:00
committed by GitHub
parent f206072216
commit 2e63da1a40
528 changed files with 1929 additions and 1928 deletions
@@ -10,7 +10,7 @@
fn f() -> i32 {
match (3) {
// CHECK:STDERR: fail_missing_default_arrow.carbon:[[@LINE+3]]:13: error(ExpectedMatchCaseArrow): expected `=>` introducing statement block
// CHECK:STDERR: fail_missing_default_arrow.carbon:[[@LINE+3]]:13: error: expected `=>` introducing statement block [ExpectedMatchCaseArrow]
// CHECK:STDERR: default { return 1; }
// CHECK:STDERR: ^
default { return 1; }