mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-11-21 21:36:39 +00:00
Move diagnostic kind name to the end of the diagnostic. (#4437)
Also surround it in square brackets rather than parentheses. This matches the format used by Clang and GCC, and means diagnostics will still match the `file:line:col: error: ` pattern used by some IDE tools. Before: ```console fail_builtins.carbon:11:11: error(AliasRequiresNameRef): alias initializer must be a name reference ``` After: ```console fail_builtins.carbon:11:11: error: alias initializer must be a name reference [AliasRequiresNameRef] ``` Also tighten up test regex to only match on `STDERR` lines that list a file name.
This commit is contained in:
1 parent
f206072216
commit
2e63da1a40
528 files changed
+1929
-1928
No files matched your search
@@ -9,13 +9,13 @@
|
||||
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/parse/testdata/generics/interface/fail_self_param_syntax.carbon
|
||||
|
||||
interface Foo {
|
||||
// CHECK:STDERR: fail_self_param_syntax.carbon:[[@LINE+4]]:13: error(ExpectedBindingPattern): expected `:` or `:!` in binding pattern
|
||||
// CHECK:STDERR: fail_self_param_syntax.carbon:[[@LINE+4]]:13: error: expected `:` or `:!` in binding pattern [ExpectedBindingPattern]
|
||||
// CHECK:STDERR: fn Sub[me Self](b: Self) -> Self;
|
||||
// CHECK:STDERR: ^~~~
|
||||
// CHECK:STDERR:
|
||||
fn Sub[me Self](b: Self) -> Self;
|
||||
|
||||
// CHECK:STDERR: fail_self_param_syntax.carbon:[[@LINE+3]]:10: error(ExpectedBindingPattern): expected name in binding pattern
|
||||
// CHECK:STDERR: fail_self_param_syntax.carbon:[[@LINE+3]]:10: error: expected name in binding pattern [ExpectedBindingPattern]
|
||||
// CHECK:STDERR: fn Mul[Self](b: Self) -> Self;
|
||||
// CHECK:STDERR: ^~~~
|
||||
fn Mul[Self](b: Self) -> Self;
|
||||
|
||||
Reference in new issue
Block a user