carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-04 22:02:52 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Rename type's GetInstId to GetTypeInstId, reflecting returned type (#6708)

Browse Source 
Discussed briefly [on
Discord](https://discord.com/channels/655572317891461132/655578254970716160/1470442830118912265),
done to reduce confusion.

Assisted-by: Google Antigravity with Gemini 3 Flash
This commit is contained in:
Jon Ross-Perkins
2026-02-09 22:00:21 +00:00
committed by GitHub
parent a465018fec
commit 2c6d9c7f66
41 changed files with 99 additions and 91 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/function.cpp
+4 -3
View File
@@ -103,7 +103,7 @@ auto MakeBuiltinFunction(Context& context, SemIR::LocId loc_id,
BeginSubpattern(context);
auto self_type_region_id = EndSubpatternAsExpr(
context, context.types().GetInstId(signature.self_type_id));
context, context.types().GetTypeInstId(signature.self_type_id));
self_param_id = AddParamPattern(context, loc_id, SemIR::NameId::SelfValue,
self_type_region_id, signature.self_type_id,
@@ -124,7 +124,7 @@ auto MakeBuiltinFunction(Context& context, SemIR::LocId loc_id,
for (auto param_type_id : signature.param_type_ids) {
BeginSubpattern(context);
auto param_type_region_id = EndSubpatternAsExpr(
context, context.types().GetInstId(param_type_id));
context, context.types().GetTypeInstId(param_type_id));
context.inst_block_stack().AddInstId(AddParamPattern(
context, loc_id, SemIR::NameId::Underscore, param_type_region_id,
@@ -140,7 +140,8 @@ auto MakeBuiltinFunction(Context& context, SemIR::LocId loc_id,
.type_id = SemIR::TypeId::None};
if (signature.return_type_id.has_value()) {
return_form = ExprAsReturnForm(
context, loc_id, context.types().GetInstId(signature.return_type_id));
context, loc_id,
context.types().GetTypeInstId(signature.return_type_id));
return_patterns_id = AddReturnPatterns(context, loc_id, return_form);
}