carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-09-25 11:50:13 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Add tests to the cpp_refactoring tool. (#539)

Browse Source 
This refactors the main.cpp out into a file structure that should make it easier to add more matchers/tests.
This commit is contained in:
Jon Meow
2021-05-17 16:55:50 -07:00
committed by GitHub
parent 231264e0c0
commit 29bf305539
9 changed files with 333 additions and 78 deletions
Download Patch File Download Diff File Expand all files Collapse all files
migrate_cpp/cpp_refactoring/main.cpp
+3 -76
View File
@@ -2,90 +2,17 @@
// Exceptions. See /LICENSE for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
#include "clang/ASTMatchers/ASTMatchFinder.h"
#include "clang/ASTMatchers/ASTMatchers.h"
#include "clang/Tooling/CommonOptionsParser.h"
#include "clang/Tooling/Refactoring.h"
#include "migrate_cpp/cpp_refactoring/fn_inserter.h"
namespace cam = ::clang::ast_matchers;
namespace ct = ::clang::tooling;
namespace Carbon {
class Matcher : public cam::MatchFinder::MatchCallback {
public:
explicit Matcher(std::map<std::string, ct::Replacements>& in_replacements)
: replacements(&in_replacements) {}
~Matcher() override = default;
void AddReplacement(const clang::SourceManager& sm,
clang::CharSourceRange range,
llvm::StringRef replacement_text) {
if (!range.isValid()) {
llvm::errs() << "Invalid range: " << range.getAsRange().printToString(sm)
<< "\n";
return;
}
if (sm.getDecomposedLoc(range.getBegin()).first !=
sm.getDecomposedLoc(range.getEnd()).first) {
llvm::errs() << "Range spans macro expansions: "
<< range.getAsRange().printToString(sm) << "\n";
return;
}
if (sm.getFileID(range.getBegin()) != sm.getFileID(range.getEnd())) {
llvm::errs() << "Range spans files: "
<< range.getAsRange().printToString(sm) << "\n";
return;
}
auto rep =
ct::Replacement(sm, sm.getExpansionRange(range), replacement_text);
auto err = (*replacements)[std::string(rep.getFilePath())].add(rep);
if (err) {
llvm::report_fatal_error("Error with replacement `" + rep.toString() +
"`: " + llvm::toString(std::move(err)) + "\n");
}
}
private:
std::map<std::string, ct::Replacements>* replacements;
};
class FnInserter : public Matcher {
public:
explicit FnInserter(std::map<std::string, ct::Replacements>& in_replacements,
cam::MatchFinder* finder)
: Matcher(in_replacements) {
finder->addMatcher(cam::functionDecl(cam::isExpansionInMainFile(),
cam::hasTrailingReturn())
.bind(Label),
this);
}
void run(const cam::MatchFinder::MatchResult& result) override {
// The matched 'if' statement was bound to 'ifStmt'.
const auto* decl = result.Nodes.getNodeAs<clang::FunctionDecl>(Label);
if (!decl) {
llvm::report_fatal_error(std::string("getNodeAs failed for ") + Label);
}
auto begin = decl->getBeginLoc();
// Replace the first token in the range, `auto`.
auto range = clang::CharSourceRange::getTokenRange(begin, begin);
AddReplacement(*(result.SourceManager), range, "fn");
}
private:
static constexpr char Label[] = "FnInserter";
};
} // namespace Carbon
auto main(int argc, const char** argv) -> int {
llvm::cl::OptionCategory category("C++ refactoring options");
clang::tooling::CommonOptionsParser op(argc, argv, category);
clang::tooling::RefactoringTool tool(op.getCompilations(),
op.getSourcePathList());
ct::CommonOptionsParser op(argc, argv, category);
ct::RefactoringTool tool(op.getCompilations(), op.getSourcePathList());
// Set up AST matcher callbacks.
cam::MatchFinder finder;