Modify EnumBase to better support the namespacing of toolchain (#3156)

The different approach to Names avoids the issues with trying to define
a static member (or also member function) of the templated instance of
Carbon::Internal::EnumBase from a non-enclosing namespace such as
Carbon::SemIR.

Note, I'm trying to do this from the cpp file. An alternative might be
to do `inline constexpr llvm::StringLiteral Names[]` in the .h file, but
I think concerns had been raised about that needing deduplication.
This commit is contained in:
Jon Ross-Perkins
2023-08-26 00:17:25 +00:00
committed by GitHub
parent 4b4436f692
commit 29b6399e4f
10 changed files with 65 additions and 110 deletions
-1
View File
@@ -15,6 +15,5 @@ CARBON_DEFINE_ENUM_CLASS_NAMES(AstRttiNodeKind) = {
CARBON_ENUM_NAME_FUNCTION(C##Kind) { \
return AstRttiNodeKind(static_cast<const C##Kind&>(*this)).name(); \
}
CARBON_AST_FOR_EACH_ABSTRACT_CLASS(DEFINE_NAME_FUNCTION)
} // namespace Carbon