carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 09:11:05 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Require that InvalidParse nodes must have an error (#4482)

Browse Source 
Unifies some boilerplate AddLeafNode calls for InvalidParse, and checks
has_error in AddNode.
This commit is contained in:
Jon Ross-Perkins
2024-11-05 00:40:08 +00:00
committed by GitHub
parent 26e58b4587
commit 2841e9a67e
10 changed files with 31 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/parse/handle_if_expr.cpp
+5 -8
View File
@@ -24,11 +24,9 @@ auto HandleIfExprFinishCondition(Context& context) -> void {
if (!state.has_error) {
context.emitter().Emit(*context.position(), ExpectedThenAfterIf);
}
// Add placeholders for `IfExprThen` and final `Expr`.
context.AddLeafNode(NodeKind::InvalidParse, *context.position(),
/*has_error=*/true);
context.AddLeafNode(NodeKind::InvalidParse, *context.position(),
/*has_error=*/true);
// Add invalid nodes to substitute for `IfExprThen` and the final `Expr`.
context.AddInvalidParse(*context.position());
context.AddInvalidParse(*context.position());
context.ReturnErrorOnState();
}
}
@@ -49,9 +47,8 @@ auto HandleIfExprFinishThen(Context& context) -> void {
if (!state.has_error) {
context.emitter().Emit(*context.position(), ExpectedElseAfterIf);
}
// Add placeholder for the final `Expr`.
context.AddLeafNode(NodeKind::InvalidParse, *context.position(),
/*has_error=*/true);
// Add an invalid node to substitute for the final `Expr`.
context.AddInvalidParse(*context.position());
context.ReturnErrorOnState();
}
}