carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 09:21:04 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Require that InvalidParse nodes must have an error (#4482)

Browse Source 
Unifies some boilerplate AddLeafNode calls for InvalidParse, and checks
has_error in AddNode.
This commit is contained in:
Jon Ross-Perkins
2024-11-05 00:40:08 +00:00
committed by GitHub
parent 26e58b4587
commit 2841e9a67e
10 changed files with 31 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/parse/context.cpp
+4 -3
View File
@@ -39,13 +39,14 @@ Context::Context(Tree& tree, Lex::TokenizedBuffer& tokens,
auto Context::ReplacePlaceholderNode(int32_t position, NodeKind kind,
Lex::TokenIndex token, bool has_error)
-> void {
CARBON_CHECK(
kind != NodeKind::InvalidParse && kind != NodeKind::InvalidParseSubtree,
"{0} shouldn't occur in Placeholder use-cases", kind);
CARBON_CHECK(position >= 0 && position < tree_->size(),
"position: {0} size: {1}", position, tree_->size());
auto* node_impl = &tree_->node_impls_[position];
CARBON_CHECK(node_impl->kind == NodeKind::Placeholder);
node_impl->kind = kind;
node_impl->has_error = has_error;
node_impl->token = token;
*node_impl = {.kind = kind, .has_error = has_error, .token = token};
}
auto Context::ConsumeAndAddOpenParen(Lex::TokenIndex default_token,