carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-04 15:11:07 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Fix clang_decls InstId for generic class export (#7633)

Browse Source 
The exported class was being inserted with a type inst ID as the key
(and looked up that way elsewhere), but when checking if the generic
class was already exported, the `first_decl_id` was being used. Make it
consistent, and opt for `first_decl_id` everywhere since it provides a
better location for diagnostics.
This commit is contained in:
Nicholas Bishop
2026-08-13 17:30:20 +00:00
committed by GitHub
parent 4ea5ef45dd
commit 2784f33221
4 changed files with 22 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/testdata/interop/cpp/function/export/constructor.carbon
Vendored
+11 -5
View File
@@ -160,12 +160,18 @@ class GenericClass(T: type) {
inline Cpp '''
void f() {
// CHECK:STDERR: fail_todo_call_generic_class_constructor.carbon:[[@LINE+7]]:29: error: no matching constructor for initialization of 'Carbon::GenericClass<int>' [CppInteropParseError]
// CHECK:STDERR: 24 | Carbon::GenericClass<int> c(0);
// CHECK:STDERR: fail_todo_call_generic_class_constructor.carbon:[[@LINE+13]]:29: error: no matching constructor for initialization of 'Carbon::GenericClass<int>' [CppInteropParseError]
// CHECK:STDERR: 30 | Carbon::GenericClass<int> c(0);
// CHECK:STDERR: | ^ ~
// CHECK:STDERR: note: candidate constructor (the implicit copy constructor) not viable: no known conversion from 'int' to 'const GenericClass<int>' for 1st argument [CppInteropParseNote]
// CHECK:STDERR: note: candidate constructor (the implicit move constructor) not viable: no known conversion from 'int' to 'GenericClass<int>' for 1st argument [CppInteropParseNote]
// CHECK:STDERR: note: candidate constructor (the implicit default constructor) not viable: requires 0 arguments, but 1 was provided [CppInteropParseNote]
// CHECK:STDERR: fail_todo_call_generic_class_constructor.carbon:[[@LINE-15]]:29: note: candidate constructor (the implicit copy constructor) not viable: no known conversion from 'int' to 'const GenericClass<int>' for 1st argument [CppInteropParseNote]
// CHECK:STDERR: 5 | class GenericClass(T: type) {
// CHECK:STDERR: | ^
// CHECK:STDERR: fail_todo_call_generic_class_constructor.carbon:[[@LINE-18]]:29: note: candidate constructor (the implicit move constructor) not viable: no known conversion from 'int' to 'GenericClass<int>' for 1st argument [CppInteropParseNote]
// CHECK:STDERR: 5 | class GenericClass(T: type) {
// CHECK:STDERR: | ^
// CHECK:STDERR: fail_todo_call_generic_class_constructor.carbon:[[@LINE-21]]:29: note: candidate constructor (the implicit default constructor) not viable: requires 0 arguments, but 1 was provided [CppInteropParseNote]
// CHECK:STDERR: 5 | class GenericClass(T: type) {
// CHECK:STDERR: | ^
// CHECK:STDERR:
Carbon::GenericClass<int> c(0);
}