carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-09-26 22:02:30 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

[executable semantics] class-ify Declaration (#307)

Browse Source 
* [executable semantics] class-ify Declaration

NFC (no functional change).

Proof of concept that we can simplify code by replacing unions with safer, more
regular types.  Hand-rolled existentials (type-erasing CoW wrappers) are a follow-on
step that will further simplify usage.

Began adding `const` where possible, and replacing `std::string*` with
`std::string`.  Most `const`s can disappear as we replace reference semantics
with value semantics, but in the meantime it's an important step in the right
direction.
This commit is contained in:
Dave Abrahams
2021-02-27 13:32:03 -08:00
committed by GitHub
parent cd57024042
commit 2205fd52ce
14 changed files with 191 additions and 210 deletions
Download Patch File Download Diff File Expand all files Collapse all files
executable_semantics/ast/function_definition.cpp
+2 -2
View File
@@ -20,7 +20,7 @@ auto MakeFunDef(int line_num, std::string name, Expression* ret_type,
return f;
}
void PrintFunDefDepth(struct FunctionDefinition* f, int depth) {
void PrintFunDefDepth(const FunctionDefinition* f, int depth) {
std::cout << "fn " << f->name << " ";
PrintExp(f->param_pattern);
std::cout << " -> ";
@@ -34,6 +34,6 @@ void PrintFunDefDepth(struct FunctionDefinition* f, int depth) {
}
}
void PrintFunDef(struct FunctionDefinition* f) { PrintFunDefDepth(f, -1); }
void PrintFunDef(const FunctionDefinition* f) { PrintFunDefDepth(f, -1); }
} // namespace Carbon