carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-06 08:34:43 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Fix use of keyword names in qualifiers with params (#5130)

Browse Source 
This is a crash bug, since NameQualifierWithParams needs a specific open
kind. I'd missed that this wasn't actually tested.
This commit is contained in:
Jon Ross-Perkins
2025-03-14 20:16:01 +00:00
committed by GitHub
parent 417b3833e2
commit 21687e8cb1
8 changed files with 67 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/node_stack.h
+2 -1
View File
@@ -472,12 +472,14 @@ class NodeStack {
case Parse::NodeKind::ForHeader:
case Parse::NodeKind::ForHeaderStart:
case Parse::NodeKind::ForIn:
case Parse::NodeKind::IdentifierNameQualifierWithParams:
case Parse::NodeKind::IdentifierNameQualifierWithoutParams:
case Parse::NodeKind::IdentifierPackageName:
case Parse::NodeKind::IfConditionStart:
case Parse::NodeKind::ImportIntroducer:
case Parse::NodeKind::IndexExprStart:
case Parse::NodeKind::InvalidParseStart:
case Parse::NodeKind::KeywordNameQualifierWithParams:
case Parse::NodeKind::KeywordNameQualifierWithoutParams:
case Parse::NodeKind::LibraryIntroducer:
case Parse::NodeKind::LibrarySpecifier:
@@ -498,7 +500,6 @@ class NodeStack {
case Parse::NodeKind::MatchStatementStart:
case Parse::NodeKind::NamedConstraintDefinitionStart:
case Parse::NodeKind::NamedConstraintIntroducer:
case Parse::NodeKind::NameQualifierWithParams:
case Parse::NodeKind::NamespaceStart:
case Parse::NodeKind::PackageIntroducer:
case Parse::NodeKind::ParenExprStart: