From 2140a57294516698b8f445fba1e3cec7bb5bc949 Mon Sep 17 00:00:00 2001 From: Dana Jansens Date: Wed, 13 Aug 2025 12:01:31 -0400 Subject: [PATCH] Remove todo in facet_type.cpp after exploration (#5950) We looked at it in https://github.com/carbon-language/carbon-lang/pull/5947 and decided not to proceed with it. --- toolchain/check/facet_type.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/toolchain/check/facet_type.cpp b/toolchain/check/facet_type.cpp index 0069528f34db..ec5ffb59cdfd 100644 --- a/toolchain/check/facet_type.cpp +++ b/toolchain/check/facet_type.cpp @@ -627,8 +627,6 @@ auto MakePeriodSelfFacetValue(Context& context, SemIR::TypeId self_type_id) // `None` because there is no equivalent non-symbolic value. .value_id = SemIR::InstId::None, })); - // TODO: LookupOrAddName should (optionally?) take a callback to run and - // construct the `inst_id` only if it's not found by lookup. auto existing = context.scope_stack().LookupOrAddName(SemIR::NameId::PeriodSelf, inst_id); // Shouldn't have any names in newly created scope.