carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Fix language-server crash with cpp_ast (#5604)

Browse Source 
Removes the nullptr default for safety.

Note, I think cpp support doesn't allow things like `<version>` or
inline code yet, and language-server support doesn't allow non-hermetic
files, so the best I can test is an error.
This commit is contained in:
Jon Ross-Perkins
2025-06-03 22:09:51 +00:00
committed by GitHub
parent c0cdc712e9
commit 20c20595ba
4 changed files with 102 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/diagnostics/coverage_test.cpp
+14 -9
View File
@@ -19,6 +19,20 @@ constexpr Kind Kinds[] = {
#include "toolchain/diagnostics/diagnostic_kind.def"
};
// TODO: LanguageServerDiagnosticInWrongFile currently has coverage, but
// mainly due to incorrect behavior in C++ diagnostics. See
// language_server/testdata/text_document/open_with_cpp_nonexistent.carbon.
// Leaving this TODO here until it's more precisely tested, because the C++
// diagnostics should be fixed (removing coverage); see below TODO.
//
// TODO: This can only fire if the first message in a diagnostic is rooted
// in a file other than the file being compiled. The language server
// currently only supports compiling one file at a time. Do one of:
// - When imports are supported, find a diagnostic whose first message isn't
// in the current file.
// - Require all diagnostics produced by compiling have their first location
// be in the file being compiled, never an import.
// Kind::LanguageServerDiagnosticInWrongFile,
constexpr Kind UntestedKinds[] = {
// These exist only for unit tests.
Kind::TestDiagnostic,
@@ -42,15 +56,6 @@ constexpr Kind UntestedKinds[] = {
// This is a little long but is tested in lex/numeric_literal_test.cpp.
Kind::TooManyDigits,
// TODO: This can only fire if the first message in a diagnostic is rooted
// in a file other than the file being compiled. The language server
// currently only supports compiling one file at a time. Do one of:
// - When imports are supported, find a diagnostic whose first message isn't
// in the current file.
// - Require all diagnostics produced by compiling have their first location
// be in the file being compiled, never an import.
Kind::LanguageServerDiagnosticInWrongFile,
};
// Looks for diagnostic kinds that aren't covered by a file_test.