carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Allow incomplete return types in function declarations. (#3875)

Browse Source 
Move completeness check to the point where the function is defined or
first called. This means we also defer deciding whether the function has
a return slot until that point. Instead of storing a return slot per
function, store the location of the return storage, which may or may not
be used, and compute and store a separate flag saying whether to use it
at the point of first use or definition.

This is the final piece in supporting simple `Make` functions in classes
as a replacement for constructors.
This commit is contained in:
Richard Smith
2024-04-11 07:23:56 +00:00
committed by GitHub
parent 28ceb4dd4e
commit 1b335402d1
173 changed files with 980 additions and 615 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/testdata/pointer/address_of_deref.carbon
Vendored
+1 -1
View File
@@ -23,7 +23,7 @@ fn F() -> i32 {
// CHECK:STDOUT: }
// CHECK:STDOUT: %Core: <namespace> = namespace [template] {}
// CHECK:STDOUT: %F: <function> = fn_decl @F [template] {
// CHECK:STDOUT: %return.var: ref i32 = var <return slot>
// CHECK:STDOUT: @F.%return: ref i32 = var <return slot>
// CHECK:STDOUT: }
// CHECK:STDOUT: }
// CHECK:STDOUT:
toolchain/check/testdata/pointer/basic.carbon
Vendored
+1 -1
View File
@@ -25,7 +25,7 @@ fn F() -> i32 {
// CHECK:STDOUT: }
// CHECK:STDOUT: %Core: <namespace> = namespace [template] {}
// CHECK:STDOUT: %F: <function> = fn_decl @F [template] {
// CHECK:STDOUT: %return.var: ref i32 = var <return slot>
// CHECK:STDOUT: @F.%return: ref i32 = var <return slot>
// CHECK:STDOUT: }
// CHECK:STDOUT: }
// CHECK:STDOUT:
toolchain/check/testdata/pointer/fail_address_of_value.carbon
Vendored
+2 -2
View File
@@ -134,11 +134,11 @@ fn AddressOfParam(param: i32) {
// CHECK:STDOUT: }
// CHECK:STDOUT: %Core: <namespace> = namespace [template] {}
// CHECK:STDOUT: %G: <function> = fn_decl @G [template] {
// CHECK:STDOUT: %return.var.loc7: ref i32 = var <return slot>
// CHECK:STDOUT: @G.%return: ref i32 = var <return slot>
// CHECK:STDOUT: }
// CHECK:STDOUT: %H: <function> = fn_decl @H [template] {
// CHECK:STDOUT: %.loc9: type = struct_type {.a: i32} [template = constants.%.1]
// CHECK:STDOUT: %return.var.loc9: ref {.a: i32} = var <return slot>
// CHECK:STDOUT: @H.%return: ref {.a: i32} = var <return slot>
// CHECK:STDOUT: }
// CHECK:STDOUT: %AddressOfLiteral: <function> = fn_decl @AddressOfLiteral [template] {}
// CHECK:STDOUT: %AddressOfOperator: <function> = fn_decl @AddressOfOperator [template] {}
toolchain/check/testdata/pointer/fail_type_mismatch.carbon
Vendored
+1 -1
View File
@@ -38,7 +38,7 @@ fn ConstMismatch(p: const {}*) -> const ({}*) {
// CHECK:STDOUT: %.loc7_43.2: type = converted %.loc7_43.1, constants.%.1 [template = constants.%.1]
// CHECK:STDOUT: %.loc7_44: type = ptr_type {} [template = constants.%.4]
// CHECK:STDOUT: %.loc7_35: type = const_type {}* [template = constants.%.5]
// CHECK:STDOUT: %return.var: ref const ({}*) = var <return slot>
// CHECK:STDOUT: @ConstMismatch.%return: ref const ({}*) = var <return slot>
// CHECK:STDOUT: }
// CHECK:STDOUT: }
// CHECK:STDOUT:
toolchain/check/testdata/pointer/nested_const.carbon
Vendored
+1 -1
View File
@@ -34,7 +34,7 @@ fn F(p: const (const (const i32*)*)) -> const i32 {
// CHECK:STDOUT: %p.loc8_6.1: const (const (const i32*)*) = param p
// CHECK:STDOUT: @F.%p: const (const (const i32*)*) = bind_name p, %p.loc8_6.1
// CHECK:STDOUT: %.loc8_41: type = const_type i32 [template = constants.%.1]
// CHECK:STDOUT: %return.var: ref const i32 = var <return slot>
// CHECK:STDOUT: @F.%return: ref const i32 = var <return slot>
// CHECK:STDOUT: }
// CHECK:STDOUT: }
// CHECK:STDOUT:
toolchain/check/testdata/pointer/types.carbon
Vendored
+2 -2
View File
@@ -32,7 +32,7 @@ fn ConstPtr(p: const i32*) -> (const i32)* {
// CHECK:STDOUT: %p.loc7_8.1: i32* = param p
// CHECK:STDOUT: @Ptr.%p: i32* = bind_name p, %p.loc7_8.1
// CHECK:STDOUT: %.loc7_23: type = ptr_type i32 [template = constants.%.1]
// CHECK:STDOUT: %return.var.loc7: ref i32* = var <return slot>
// CHECK:STDOUT: @Ptr.%return: ref i32* = var <return slot>
// CHECK:STDOUT: }
// CHECK:STDOUT: %ConstPtr: <function> = fn_decl @ConstPtr [template] {
// CHECK:STDOUT: %.loc11_16: type = const_type i32 [template = constants.%.2]
@@ -41,7 +41,7 @@ fn ConstPtr(p: const i32*) -> (const i32)* {
// CHECK:STDOUT: @ConstPtr.%p: const i32* = bind_name p, %p.loc11_13.1
// CHECK:STDOUT: %.loc11_32: type = const_type i32 [template = constants.%.2]
// CHECK:STDOUT: %.loc11_42: type = ptr_type const i32 [template = constants.%.3]
// CHECK:STDOUT: %return.var.loc11: ref const i32* = var <return slot>
// CHECK:STDOUT: @ConstPtr.%return: ref const i32* = var <return slot>
// CHECK:STDOUT: }
// CHECK:STDOUT: }
// CHECK:STDOUT: