carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-04 22:02:52 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Move add invalid node. Follow up to #3473. (#3491)

Browse Source 
I think this matches expectations about how the parse code should be
structured better.
This commit is contained in:
josh11b
2023-12-11 17:22:17 +00:00
committed by GitHub
parent 5f439b842b
commit 1addf10054
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/parse/handle_impl.cpp
+5 -2
View File
@@ -34,6 +34,11 @@ auto HandleImplAfterIntroducer(Carbon::Parse::Context& context) -> void {
"Expected `[` after `forall` in `impl` declaration.");
context.emitter().Emit(*context.position(), ImplExpectedAfterForall);
context.ReturnErrorOnState();
// If we aren't producing a node from the PatternListAsImplicit state,
// we still need to create a node to be the child of the `ImplForall`
// token created in the `ImplAfterForall` state.
context.AddLeafNode(NodeKind::InvalidParse, *context.position(),
/*has_error=*/true);
}
} else {
// One of:
@@ -46,8 +51,6 @@ auto HandleImplAfterIntroducer(Carbon::Parse::Context& context) -> void {
auto HandleImplAfterForall(Carbon::Parse::Context& context) -> void {
auto state = context.PopState();
if (state.has_error) {
context.AddLeafNode(NodeKind::InvalidParse, *context.position(),
/*has_error=*/true);
context.ReturnErrorOnState();
}
context.AddNode(NodeKind::ImplForall, state.token, state.subtree_start,