carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

When diagnosing poisoned name, point to the declared name instead of the entire declaration (#4938)

Browse Source 
See
https://discord.com/channels/655572317891461132/655578254970716160/1339007384361762857.

Part of #4622.
This commit is contained in:
Boaz Brickner
2025-02-12 20:59:55 +00:00
committed by GitHub
parent b78ab1bbae
commit 1aa6573d4e
9 changed files with 39 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/decl_name_stack.cpp
+2 -1
View File
@@ -175,7 +175,8 @@ auto DeclNameStack::AddNameOrDiagnose(NameContext name_context,
SemIR::InstId target_id,
SemIR::AccessKind access_kind) -> void {
if (name_context.state == DeclNameStack::NameContext::State::Poisoned) {
context_->DiagnosePoisonedName(name_context.poisoning_loc_id, target_id);
context_->DiagnosePoisonedName(name_context.poisoning_loc_id,
name_context.loc_id);
} else if (auto id = name_context.prev_inst_id(); id.has_value()) {
context_->DiagnoseDuplicateName(target_id, id);
} else {