carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-09-24 22:02:23 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Rename factory functions from 'Create' to 'Make' (#3706)

Browse Source 
Similar to #3705, we actually have a mix of `Make` and `Create` in
factory functions too, so this PR is normalizing on `Make`. It's
intended to be consistent with the naming choice for Carbon factory
functions.

Note, MakeSyntheticBlock is the only one I feel a little weird about
because llvm's own APIs use Create, and this is essentially wrapping
LLVM calls. But the flipside is it also feels like a vague line to draw,
when we also differ from LLVM coding style in other ways.
This commit is contained in:
Jon Ross-Perkins
2024-02-14 18:26:56 +00:00
committed by GitHub
parent 4873160acc
commit 1974e44fd9
24 changed files with 66 additions and 68 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/source/source_buffer_test.cpp
+8 -8
View File
@@ -17,8 +17,8 @@ static constexpr llvm::StringLiteral TestFileName = "test.carbon";
TEST(SourceBufferTest, MissingFile) {
llvm::vfs::InMemoryFileSystem fs;
auto buffer = SourceBuffer::CreateFromFile(fs, TestFileName,
ConsoleDiagnosticConsumer());
auto buffer =
SourceBuffer::MakeFromFile(fs, TestFileName, ConsoleDiagnosticConsumer());
EXPECT_FALSE(buffer);
}
@@ -27,8 +27,8 @@ TEST(SourceBufferTest, SimpleFile) {
CARBON_CHECK(fs.addFile(TestFileName, /*ModificationTime=*/0,
llvm::MemoryBuffer::getMemBuffer("Hello World")));
auto buffer = SourceBuffer::CreateFromFile(fs, TestFileName,
ConsoleDiagnosticConsumer());
auto buffer =
SourceBuffer::MakeFromFile(fs, TestFileName, ConsoleDiagnosticConsumer());
ASSERT_TRUE(buffer);
EXPECT_EQ(TestFileName, buffer->filename());
@@ -44,8 +44,8 @@ TEST(SourceBufferTest, NoNull) {
/*BufferName=*/"",
/*RequiresNullTerminator=*/false)));
auto buffer = SourceBuffer::CreateFromFile(fs, TestFileName,
ConsoleDiagnosticConsumer());
auto buffer =
SourceBuffer::MakeFromFile(fs, TestFileName, ConsoleDiagnosticConsumer());
ASSERT_TRUE(buffer);
EXPECT_EQ(TestFileName, buffer->filename());
@@ -57,8 +57,8 @@ TEST(SourceBufferTest, EmptyFile) {
CARBON_CHECK(fs.addFile(TestFileName, /*ModificationTime=*/0,
llvm::MemoryBuffer::getMemBuffer("")));
auto buffer = SourceBuffer::CreateFromFile(fs, TestFileName,
ConsoleDiagnosticConsumer());
auto buffer =
SourceBuffer::MakeFromFile(fs, TestFileName, ConsoleDiagnosticConsumer());
ASSERT_TRUE(buffer);
EXPECT_EQ(TestFileName, buffer->filename());