mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-05 15:41:04 +01:00
Rename factory functions from 'Create' to 'Make' (#3706)
Similar to #3705, we actually have a mix of `Make` and `Create` in factory functions too, so this PR is normalizing on `Make`. It's intended to be consistent with the naming choice for Carbon factory functions. Note, MakeSyntheticBlock is the only one I feel a little weird about because llvm's own APIs use Create, and this is essentially wrapping LLVM calls. But the flipside is it also feels like a vague line to draw, when we also differ from LLVM coding style in other ways.
This commit is contained in:
@@ -39,7 +39,7 @@ class LexerTest : public ::testing::Test {
|
||||
std::string filename = llvm::formatv("test{0}.carbon", ++file_index_);
|
||||
CARBON_CHECK(fs_.addFile(filename, /*ModificationTime=*/0,
|
||||
llvm::MemoryBuffer::getMemBuffer(text)));
|
||||
source_storage_.push_front(std::move(*SourceBuffer::CreateFromFile(
|
||||
source_storage_.push_front(std::move(*SourceBuffer::MakeFromFile(
|
||||
fs_, filename, ConsoleDiagnosticConsumer())));
|
||||
return source_storage_.front();
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user