carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Rename factory functions from 'Create' to 'Make' (#3706)

Browse Source 
Similar to #3705, we actually have a mix of `Make` and `Create` in
factory functions too, so this PR is normalizing on `Make`. It's
intended to be consistent with the naming choice for Carbon factory
functions.

Note, MakeSyntheticBlock is the only one I feel a little weird about
because llvm's own APIs use Create, and this is essentially wrapping
LLVM calls. But the flipside is it also feels like a vague line to draw,
when we also differ from LLVM coding style in other ways.
This commit is contained in:
Jon Ross-Perkins
2024-02-14 18:26:56 +00:00
committed by GitHub
parent 4873160acc
commit 1974e44fd9
24 changed files with 66 additions and 68 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/driver/driver.cpp
+5 -5
View File
@@ -410,12 +410,12 @@ class Driver::CompilationUnit {
// Loads source and lexes it. Returns true on success.
auto RunLex() -> bool {
LogCall("SourceBuffer::CreateFromFile", [&] {
LogCall("SourceBuffer::MakeFromFile", [&] {
if (input_file_name_ == "-") {
source_ = SourceBuffer::CreateFromStdin(*consumer_);
source_ = SourceBuffer::MakeFromStdin(*consumer_);
} else {
source_ = SourceBuffer::CreateFromFile(driver_->fs_, input_file_name_,
*consumer_);
source_ = SourceBuffer::MakeFromFile(driver_->fs_, input_file_name_,
*consumer_);
}
});
if (!source_) {
@@ -514,7 +514,7 @@ class Driver::CompilationUnit {
CARBON_VLOG() << "*** CodeGen ***\n";
std::optional<CodeGen> codegen =
CodeGen::Create(*module_, options_.target, driver_->error_stream_);
CodeGen::Make(*module_, options_.target, driver_->error_stream_);
if (!codegen) {
return false;
}