From 168681abce63d9cc0cec24cfc1d0caef6fa3a25f Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Tue, 9 Jun 2020 15:58:41 -0400 Subject: [PATCH] [libc++abi][libunwind] Don't override libc++'s handling of exception features 0e04342ae039 simplified exceptions-related configurations for libc++abi and libunwind by reusing the logic in libc++. However, it missed the fact that libc++abi and libunwind were overriding libc++'s handling of exceptions. This commit removes special handling in libc++abi and libunwind to use the logic in libc++, which is the right one. --- libcxxabi/test/libcxxabi/test/config.py | 3 --- libunwind/test/libunwind/test/config.py | 3 --- 2 files changed, 6 deletions(-) diff --git a/libcxxabi/test/libcxxabi/test/config.py b/libcxxabi/test/libcxxabi/test/config.py index f1eb453e09f3..37938d53a240 100644 --- a/libcxxabi/test/libcxxabi/test/config.py +++ b/libcxxabi/test/libcxxabi/test/config.py @@ -86,8 +86,5 @@ class Configuration(LibcxxConfiguration): % libunwind_headers) self.cxx.compile_flags += ['-I' + libunwind_headers] - def configure_compile_flags_exceptions(self): - pass - def configure_compile_flags_rtti(self): pass diff --git a/libunwind/test/libunwind/test/config.py b/libunwind/test/libunwind/test/config.py index 7e4f230d821c..31f6148879c5 100644 --- a/libunwind/test/libunwind/test/config.py +++ b/libunwind/test/libunwind/test/config.py @@ -59,9 +59,6 @@ class Configuration(LibcxxConfiguration): % libunwind_headers) self.cxx.compile_flags += ['-I' + libunwind_headers] - def configure_compile_flags_exceptions(self): - pass - def configure_compile_flags_rtti(self): pass